Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add note about how to attach debugger #6273

Merged
merged 8 commits into from
Apr 25, 2024
Merged

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Dec 22, 2023

Debuggers are always helpful in debugging. This PR adds a little guide on how to do it to the CLI docs :)

@Skn0tt Skn0tt self-assigned this Dec 22, 2023
@Skn0tt Skn0tt requested a review from a team as a code owner December 22, 2023 09:06
Copy link

github-actions bot commented Dec 22, 2023

📊 Benchmark results

Comparing with 12d7464

  • Dependency count: 1,345 (no change)
  • Package size: 313 MB ⬆️ 0.00% increase vs. 12d7464
  • Number of ts-expect-error directives: 1,001 (no change)

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Matt Kane <[email protected]>
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved

1. Open this repository in VS Code.
2. Open a "JavaScript Debug Terminal" (e.g. by searching for it in the Command Palette (Shift-Cmd+P)). Every Node process that's opened in this terminal will have a debugger attached.
3. Place a breakpoint somewhere in the CLI. You will have to place them in the compiled `.js` files as opposed to the `.ts` files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we output source maps to fix this? Or is there some other limitation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we can, just wanted to document what's working for me.

biruwon
biruwon previously approved these changes Apr 25, 2024
Copy link
Contributor

@biruwon biruwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you want to fixe those warnings

@Skn0tt Skn0tt enabled auto-merge (squash) April 25, 2024 13:42
@Skn0tt
Copy link
Contributor Author

Skn0tt commented Apr 25, 2024

What warnings? I'm not seeing any 😅

CONTRIBUTING.md Outdated Show resolved Hide resolved
@Skn0tt
Copy link
Contributor Author

Skn0tt commented Apr 25, 2024

oh the ones by vale! yeah, one of them warnings was good :D

@Skn0tt Skn0tt merged commit 7907adf into main Apr 25, 2024
40 checks passed
@Skn0tt Skn0tt deleted the js-debug-terminal-docs branch April 25, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants